Fix Action Text sanitizer initialization #48753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Using
initializer
in the engine may run the block before application initializers. Instead, useconfig.after_initialize
to ensure that application initializers take effect properly.Also, don't bother deleting the config value, since that pattern isn't needed here (as it is in other railties like action_view/railtie.rb).
See similar fix for Action View in #48747.
Detail
Replace
initializer
withconfig.after_initialize
.Additional information
I'm not sure how to test this behavior properly other than to set up an application and run the code. I would love to learn how to better test initializer order.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]