Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent header wrapping in email preview #48767

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Jul 19, 2023

Motivation / Background

In the all header view in email previews, header names may wrap if the header value is very long (see screenshot). Header names are usually short, so I suggest we don't wrap those.

Screenshot

Before

image

After

image

Checklist

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • [n/a] Tests are added or updated if you fix a bug or add a feature.
  • [n/a] CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the railties label Jul 19, 2023
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this looks better, thanks!

@carlosantoniodasilva carlosantoniodasilva merged commit 31d66f7 into rails:main Oct 12, 2023
9 checks passed
rafaelfranca pushed a commit that referenced this pull request Oct 12, 2023
Prevent header wrapping in email preview
@c960657 c960657 deleted the mailer-preview-wrap branch November 2, 2023 13:03
@c960657
Copy link
Contributor Author

c960657 commented Nov 2, 2023

@carlosantoniodasilva Thank you for reviewing and merging this.

I have made a few other improvements to the mailer preview that you might want to consider:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants