Adds Arel::FactoryMethods#cast(node, type) #48873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drnic
force-pushed
the
arel-cast-function
branch
from
1fd0b66
to
88d5172
Compare
rafaelfranca
reviewed
Aug 2, 2023
For example: product_table = Product.arel_table product_table.cast(product_table[:position], "integer") Produces SQL: CAST(position as integer)
drnic
force-pushed
the
arel-cast-function
branch
from
88d5172
to
32bdff4
Compare
|
I'll investigate the new build failures and make a fix |
The result of the SQL is not the same on all databases, so writing a test that would pass in all cases would mean conditionals here. Since we already testing if the SQL results of a As node is correct in the visitor tests, we only need to check if the As node attributes are correct here.
|
This error is just a quote discrepancy between the adapters. I pushed a commit to this PR with the fix. Since we are already testing the SQL result of visiting a |
|
Gotcha. It seemed "right" to confirm the final SQL; but I was naive to assume all the adapters printed the same thing. Thanks for making time to fix and the explanations @rafaelfranca |
|
Thank you for implementing the feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
Produces SQL:
Motivation / Background
CAST(field as type)is a widely supported SQL function. This PR adds native arel support for this named function with acast(field, type)helper.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]