Fix host display when X_FORWARDED_HOST authorized #48941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a Request had a non-authorized HTTP_HOST but an authorized HTTP_X_FORWARDED_HOST, the HTTP_X_FORWARDED_HOST value would be displayed as the one being blocked. However, this could be confusing for users since that value would already be added to `config.hosts`. This commit addresses the issue by tweaking how the blocked host is displayed. Instead of always displaying Request#host (which will return X_FORWARDED_HOST when present whether or not that's the host being blocked), each host being blocked will be displayed on its own. Co-authored-by: Daniel Schlosser <Eusebius1920@users.noreply.github.com>
skipkayhil
commented
Aug 15, 2023
| @@ -284,7 +284,7 @@ class HostAuthorizationTest < ActionDispatch::IntegrationTest | |||
| } | |||
|
|
|||
| assert_response :forbidden | |||
| assert_match "Blocked host: 127.0.0.1", response.body | |||
| assert_match "Blocked hosts: www.example.com", response.body | |||
There was a problem hiding this comment.
This and the other test change demonstrate the issue: the displayed blocked host previously would be HTTP_X_FORWARDED_HOST even though that value was already added to config.hosts. The correct value here should be HTTP_HOST
rafaelfranca
added a commit
that referenced
this pull request
Aug 21, 2023
Fix host display when X_FORWARDED_HOST authorized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Previously, when a Request had a non-authorized HTTP_HOST but an authorized HTTP_X_FORWARDED_HOST, the HTTP_X_FORWARDED_HOST value would be displayed as the one being blocked. However, this could be confusing for users since that value would already be added to
config.hosts.Detail
This commit addresses the issue by tweaking how the blocked host is displayed. Instead of always displaying Request#host (which will return X_FORWARDED_HOST when present whether or not that's the host being blocked), each host being blocked will be displayed on its own.
Additional information
Fixes #40230
Supercedes #46158
cc @Eusebius1920 I added you as a coauthor for your work on the previous PR
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]