Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method name to check_all_pending! #48964

Merged
merged 1 commit into from Aug 17, 2023
Merged

Conversation

sinsoku
Copy link
Contributor

@sinsoku sinsoku commented Aug 17, 2023

Motivation / Background

Because check_pending_migrations! mentioned in the warning message does not exist.

Detail

The method added in 03379d1 is check_all_pending!, not check_pending_migrations!.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • [-] Tests are added or updated if you fix a bug or add a feature.
  • [-] CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

The method added in 03379d1 is `check_all_pending!`, not
`check_pending_migrations!`.
@eileencodes eileencodes merged commit b56f938 into rails:main Aug 17, 2023
9 checks passed
@eileencodes
Copy link
Member

Thank you, can't believe I typo'd that 🤦🏼‍♀️

@sinsoku sinsoku deleted the fix-method-name branch August 18, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants