Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 6.1 change_table setting datetime precision #48974

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Fix 6.1 change_table setting datetime precision #48974

merged 1 commit into from
Aug 23, 2023

Commits on Aug 22, 2023

  1. Fix 6.1 change_table setting datetime precision 

    While working on rails#48969, I found that some of the Compatibility test
cases were not working correctly. The tests removed in this commit were
never running the `change_table` migration and so were not actually
testing that `change_table` works correctly. The issue is that the two
migrations created in these tests both have `nil` versions, and so the
Migrator only runs the first one.

This commit refactors the tests so that its easier to test the behavior
of each Migration class version (and I think the rest of the tests
should be updated to use this strategy as well). Additionally, since the
tests are fixed it exposed that `t.change` in a `change_table` is not
behaving as expected so that is fixed as well.
    @skipkayhil
    skipkayhil committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9b07b2d View commit details
    Browse the repository at this point in the history