Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webdrivers on 7-0-stable branch for issue #48973. #48977

Merged
merged 4 commits into from Aug 23, 2023

Conversation

ruyrocha
Copy link
Contributor

Motivation / Background

This Pull Request has been created because #48973

Detail

This Pull Request changes the requirement for webdrivers gem.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@ruyrocha ruyrocha force-pushed the fix/webdrivers-on-7-0-stable branch from fb26e28 to 43f47b6 Compare August 19, 2023 02:45
@rafaelfranca
Copy link
Member

rafaelfranca commented Aug 21, 2023

CI is broken. Can you take a look?

@ruyrocha
Copy link
Contributor Author

@rafaelfranca right, I'm on it.

I have two local branches - one to run UJS tests with Karma, and another one to fix i18n errors - related to these changes:

  7-0-stable
  fix-i18n-helpers
* fix/ujs-tests-with-karma
  fix/webdrivers-on-7-0-stable
  main

Since the base branch for all of those are 7-0-stable, I'll submit new PRs when they're ready.

@ruyrocha ruyrocha force-pushed the fix/webdrivers-on-7-0-stable branch from 0752fc3 to 42b4018 Compare August 23, 2023 07:32
@ruyrocha
Copy link
Contributor Author

It's green, @rafaelfranca.

Turns out that CI won't be happy without the changes on 42b4018.

@rafaelfranca rafaelfranca merged commit f9175db into rails:7-0-stable Aug 23, 2023
3 checks passed
@ruyrocha ruyrocha deleted the fix/webdrivers-on-7-0-stable branch August 23, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants