Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix defect where aliased attribute methods on abstract classes were not being defined #48991

Merged
merged 1 commit into from Aug 21, 2023
Merged

Fix defect where aliased attribute methods on abstract classes were not being defined #48991

merged 1 commit into from Aug 21, 2023

Commits on Aug 21, 2023

  1. Fix defect where aliased attribute methods on abstract classes were b… 

    …eing not defined

rails/rails@a88f47d fixed an issue where subclasses were regenerating aliased attribute methods defined on parent classes. Part of the solution was to call #generate_alias_attributes recursively on a class's superclass to generate all the alias attributes in the inheritance hierarchy. However, the implementation relies on #base_class to determine if we should call #generate_alias_attributes on the superclass. Since all models that inherit from abstract classes are base classes, this means that #generate_alias_attributes will never be called on abstract classes, meaning no method will be generated for any alias attributes defined on them.

To fix this issue, we should always call #generate_alias_attributes on the superclass unless the superclass is ActiveRecord::Base.
    @andrewn617
    andrewn617 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    211146b View commit details
    Browse the repository at this point in the history