Document where support for AR normalizes
#49105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@Earlopain Thanks for updating this 👍 . This LGTM after squashing your commits.
Also some other small changelog tweak: * Add normalize_value_for to the activerecord changelog * Fix a wrong method reference in the 7.1 release notes
|
Done! |
jonathanhefner
added a commit
that referenced
this pull request
Sep 10, 2023
In #49105, `where` examples were added to the `normalizes` documentation to demonstrate that normalizations are also applied for `where`. However, as with the `exists?` examples, we should also demonstrate that normalizations are only applied to keyword arguments, not positional arguments. We can also address the original source of the confusion by changing the wording of "finder methods" to "query methods". This commit also removes the tests added in #49105. `normalizes` works at the level of attribute types, so there is no need to test every query method. Testing `find_by` is sufficient. (And, in point of fact, `find_by` is implemented in terms of `where`.)
zzak
reviewed
Sep 27, 2023
| @@ -856,6 +856,7 @@ | |||
| ```ruby | |||
| class User < ActiveRecord::Base | |||
| normalizes :email, with: -> email { email.strip.downcase } | |||
| normalizes :phone, with: -> phone { phone.delete("^0-9").delete_prefix("1") } | |||
There was a problem hiding this comment.
@Earlopain This example is a little confusing, how about just phone.strip?
There was a problem hiding this comment.
D'oh, sorry I was mixing up the previous example because you added the where below 🤦 sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Reading through the changelog for
normalizedmade me wonder if it also works withwhere. It says it works with finder methods, but I don't thinkwhereis one of those. It works regardless, so I added it to the changelog and made some tests for it.I also noticed some inconsistencies in the changelog, fixed those up too. I hope that's ok to put in one PR.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]