Remove useless include in DescendantsTracker #49108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either we are on a modern Ruby with `Class#subclass`, in which case `DescendantsTracker#subclass` isn't defined, so we don't need the filtering module. Or we're on an old Ruby, and `DescendantsTracker.subclass` already does the filtering.
|
I can confirm this helps with a compatibility problem in TruffleRuby. We're working to fix the core issue in TruffleRuby, but it's non-trivial and obviously won't help already released versions. This PR allows Rails to run with already released versions of TruffleRuby. |
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Sep 1, 2023
Followup: rails#49108 DescendantsTracker need to work whether the `Class#descendants` core ext is loaded or not. I missed that in the previous PR.
|
Nice! |
eregon
added a commit
to eregon/yjit-bench
that referenced
this pull request
Sep 16, 2023
* This notably includes this fix which is necessary on truffleruby: rails/rails#49108
eregon
added a commit
to eregon/yjit-bench
that referenced
this pull request
Sep 18, 2023
* This notably includes this fix which is necessary on truffleruby: rails/rails#49108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either we are on a modern Ruby with
Class#subclass, in which caseDescendantsTracker#subclassisn't defined, so we don't need the filtering module.Or we're on an old Ruby, and
DescendantsTracker.subclassalready does the filtering.