New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: simple_format with blank wrapper_tag option returns plain html tag. #49120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilgkrishnan
force-pushed
the
simple-format-blank-wrapper
branch
2 times, most recently
from
September 2, 2023 15:40
33592ca
to
6049da4
Compare
akhilgkrishnan
force-pushed
the
simple-format-blank-wrapper
branch
2 times, most recently
from
September 4, 2023 09:09
6c1bbd2
to
c85deb4
Compare
akhilgkrishnan
force-pushed
the
simple-format-blank-wrapper
branch
2 times, most recently
from
September 4, 2023 09:12
0567538
to
0c71740
Compare
esasse
reviewed
Sep 4, 2023
akhilgkrishnan
force-pushed
the
simple-format-blank-wrapper
branch
2 times, most recently
from
September 4, 2023 12:51
c0fa23e
to
26fd1ab
Compare
byroot
reviewed
Sep 5, 2023
byroot
reviewed
Sep 5, 2023
akhilgkrishnan
force-pushed
the
simple-format-blank-wrapper
branch
from
September 5, 2023 09:57
26fd1ab
to
ef4136e
Compare
byroot
reviewed
Sep 5, 2023
Thanks, please just fix the changelog and after that I'll merge. |
By default `simple_format` method returns the text wrapped with `<p>`. But if we explicitly specify the `wrapper_tag: nil` in the options, it returns the text wrapped with `<></>` tag. Before: ```ruby simple_format("Hello World", {}, { wrapper_tag: nil }) # <>Hello World</> ``` After: ```ruby simple_format("Hello World", {}, { wrapper_tag: nil }) # <p>Hello World</p> ``` Co-authored-by: Junichi Ito <jit@sonicgarden.jp>
akhilgkrishnan
force-pushed
the
simple-format-blank-wrapper
branch
from
September 5, 2023 10:10
ef4136e
to
1677e31
Compare
Thank you! |
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #44948
By default
simple_format
method returns the text wrapped with<p>
. But if we explicitly specify thewrapper_tag: nil
in the options, it returns the text wrapped with<></>
tag.Detail
In this PR, it updates the behavior of the
simple_format
helper, If the user passesnil
or an empty string as a value forwrapper_tag
it defaults to use the<p>
tag for wrapping.Co-authored-by: @JunichiIto
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]