Generate secure token only once regardless of on: :initialize or on: :create
#49146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n: :create` Follow-up to rails#47420. Whereas the original behavior (`on: :create`) is invoked only once before a record is persisted, the new behavior (`on: :initialize`) is invoked not only new record but also persisted records. It should be invoked only once for new record consistently.
abeidahmed
added a commit
to abeidahmed/rails
that referenced
this pull request
Dec 3, 2023
…alize Follow-up to rails#49146 The original behavior of `has_secure_token` was to use the `send("#{attribute}=", some_value)` method so that the setter method, if defined, was called. PR rails#49146 replaced the `send` method with `write_attribute` which doesn't call the setter method and breaks existing applications.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #47420.
Whereas the original behavior (
on: :create) is invoked only once before a record is persisted, the new behavior (on: :initialize) is invoked not only new record but also persisted records.It should be invoked only once for new record consistently.