Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AbstractController::Translation.raise_on_missing_translations added to release note [skip ci] #49213

Merged

Conversation

akhilgkrishnan
Copy link
Member

This PR adds a removal change for AbstractController::Translation.raise_on_missing_translations #47115 in 7.1 release note

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the docs label Sep 10, 2023
@kamipo kamipo merged commit bb4dbd1 into rails:main Sep 11, 2023
3 checks passed
@akhilgkrishnan akhilgkrishnan deleted the action-config-removal-release-note branch September 11, 2023 06:45
@rafaelfranca
Copy link
Member

This options was never part of public API, we should not document this removal. I'm reverting.

@akhilgkrishnan
Copy link
Member Author

This options was never part of public API, we should not document this removal. I'm reverting.

If that is the case, Can I remove that from changelog as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants