Explicit primary_key: option should always take priority in associations
#49264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions This commit fixes the issue where the `primary_key:` option was ignored if the associated model had a `query_constraints` configured. Now `primary_key:` option always takes priority and only if there is no `primary_key:` option, the `query_constraints` are used to determine the `association_primary_key` value.
eileencodes
deleted the
explicitly-configured-primary-key-option-must-take-priority-in-association-primary-key
branch
There isn't a 7-1-stable yet, so we don't need a backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where the
primary_key:option was ignored if the associated model had aquery_constraintsconfigured. Nowprimary_key:option always takes priority and only if there is noprimary_key:option, thequery_constraintsare used to determine theassociation_primary_keyvalue.Technically now this is a bug in Rails 7.1 beta so I presume we want a changelog entry and the commit to be backported to
7-1-stableif such exist? Let me know whether it needs a CHANGELOG entry and how to ensure it gets included into the next release as a bugfix