Rename back unique keys to unique constraints #49383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahonda
approved these changes
Sep 26, 2023
|
Some nitpick comment. How about |
As we (I and @yahonda) talked about the naming in person, naming unique constraints as unique keys is very confusing to me. All documents and descriptions says it's unique constraints, but naming unique keys leads to misunderstanding it's a short-hand of unique indexes. Just naming it unique constraints is not misleading.
kamipo
force-pushed
the
rename_unique_constraint
branch
from
40f071a
to
b2790b6
Compare
|
Good catch, renamed. |
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Sep 26, 2023
And restore updating old ones in the CHANGELOG.
kamipo
added a commit
that referenced
this pull request
Sep 26, 2023
Add a CHANGELOG entry for #49383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we (I and @yahonda) talked about the naming in person, naming unique constraints as unique keys is very confusing to me. All documents and descriptions says it's unique constraints, but naming unique keys leads to misunderstanding it's a short-hand of unique indexes.
Just naming it unique constraints is not misleading.
cc @yahonda @alpaca-tc since unique keys is proposed at #46192