Updated @rails/ujs files to follow 8e3449908c59858384ae230d1416c7dcabc8c2dc
#49553
+73
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tricknotes
force-pushed
the
update-rails-ujs-build
branch
2 times, most recently
from
9229513
to
90d55ff
Compare
|
Nice catch! Can you add a test like this to Action View as well: https://github.com/rails/rails/blob/1dbd2fa4790329da6b2a35b00e84a5b44dea73ec/activestorage/test/javascript_package_test.rb |
|
Thanks, @skipkayhil |
Earlopain
reviewed
Oct 9, 2023
tricknotes
force-pushed
the
update-rails-ujs-build
branch
from
e3c28eb
to
4ce1330
Compare
yahonda
reviewed
Oct 10, 2023
actionview/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| * Updated `@rails/ujs` files to follow https://github.com/rails/rails/commit/8e3449908c59858384ae230d1416c7dcabc8c2dc. | |||
There was a problem hiding this comment.
Changelog entries are for users, not for framework developer/contributors. So would you rewrite the link to the commit for more meaningful message.
This change was built by `$ yarn build` in actionview. This commit includes the following changes into build files. - rails@8e34499
tricknotes
force-pushed
the
update-rails-ujs-build
branch
from
4ce1330
to
9753982
Compare
rafaelfranca
added a commit
that referenced
this pull request
Oct 11, 2023
Updated `@rails/ujs` files to follow 8e34499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because 8e34499 was not affected build files.
Since we want to use it in our application, it should be updated in build files.
Detail
This Pull Request changes
@rails/ujs.Additional information
This commit has been created by
$ yarn buildthat is defined in the following:rails/actionview/package.json
Line 14 in 1dbd2fa
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]