Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Action Text Sanitization #49696

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

seanpdoyle
Copy link
Contributor

Add documentation for ActionText::RichText#to_s and ActionText::Content#to_s that demonstrates Action Text's ability to sanitize and scrub its content.

actiontext/app/models/action_text/rich_text.rb Outdated Show resolved Hide resolved
guides/source/action_text_overview.md Outdated Show resolved Hide resolved
guides/source/action_text_overview.md Outdated Show resolved Hide resolved
actiontext/lib/action_text/content.rb Outdated Show resolved Hide resolved
Copy link
Member

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of suggestions.

guides/source/action_text_overview.md Outdated Show resolved Hide resolved
actiontext/lib/action_text/content.rb Show resolved Hide resolved
Copy link
Member

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to improve these docs!

@seanpdoyle seanpdoyle requested a review from p8 October 30, 2023 20:36
@p8
Copy link
Member

p8 commented Oct 30, 2023

Thanks @seanpdoyle ! If you squash the commits I'll merge it.

Add documentation for `ActionText::RichText#to_s` and
`ActionText::Content#to_s` that demonstrates Action Text's ability to
sanitize and scrub its content.

Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
@seanpdoyle
Copy link
Contributor Author

Squashed! Thank you.

@p8 p8 merged commit 344e59e into rails:main Oct 30, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants