Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because allows actionview to be required with defining the
Rails
constant.Detail
Once the
Rails
constant is defined, it makes it more challenging to use with frameworks like Jets with actionview because other gems that do this:some_gem/railtie.rb
won't be able to be used with Jets. Renaming to actionview-html-sanitizer gives other gems a chance to work with Jets, also.
Note: The ideal way to check would be for the other gems to use this instead:
It's a bummer, gems authors are not always aware of this.
Additional information
Related:
Note, there would need to be some sequencing for this to be release.
I tested it by installing the renamed actionview-html-sanitizer gem locally with rake install.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]