Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add racc dependency because it will be bundled #49722

Merged
merged 1 commit into from Oct 20, 2023

Conversation

skipkayhil
Copy link
Member

@skipkayhil skipkayhil commented Oct 20, 2023

Motivation / Background

Ruby 3.3.0 is going to start warning for racc not being specififed as a dependency, and Ruby 3.4.0 will raise if it is not specified.

Detail

This commit prevents those issues by adding racc to the Action Pack gemspec, since racc/parser is a runtime dependency of the Journey parser.

Additional information

Ref ruby/ruby@2a56a6c
Ref ruby/ruby#7877

Alternatively, we could vendor racc/parser into Journey's generated parser but that then requires the parser to be regenerated to get any upstream improvements

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

Ruby 3.3.0 is going to start warning for racc not being specififed as a
dependency, and Ruby 3.4.0 will raise if it is not specified.

This commit prevents those issues by adding racc to the Action Pack
gemspec, since `racc/parser` is a runtime dependency of the Journey
parser.
@rails-bot rails-bot bot added the actionpack label Oct 20, 2023
@yahonda yahonda merged commit d4866ed into rails:main Oct 20, 2023
4 checks passed
@skipkayhil skipkayhil deleted the hm-add-racc-dep branch October 20, 2023 22:10
@skipkayhil
Copy link
Member Author

@yahonda what do you think about backporting this to 7-1-stable and 7-0-stable (and also backporting #48907 to 7-0-stable as well) to ensure that 7.0 and 7.1 both show no warnings on 3.3 (and no errors on 3.4)?

@rafaelfranca
Copy link
Member

Where are we using racc in Rails?

@rafaelfranca
Copy link
Member

Ah, journey.

rafaelfranca pushed a commit that referenced this pull request Oct 23, 2023
Add racc dependency because it will be bundled
rafaelfranca pushed a commit that referenced this pull request Oct 23, 2023
Add racc dependency because it will be bundled
skipkayhil pushed a commit to skipkayhil/rails that referenced this pull request Jan 3, 2024
Add racc dependency because it will be bundled
skipkayhil pushed a commit to skipkayhil/rails that referenced this pull request Jan 3, 2024
Add racc dependency because it will be bundled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants