Add racc dependency because it will be bundled #49722
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Ruby 3.3.0 is going to start warning for racc not being specififed as a dependency, and Ruby 3.4.0 will raise if it is not specified.
Detail
This commit prevents those issues by adding racc to the Action Pack gemspec, since
racc/parser
is a runtime dependency of the Journey parser.Additional information
Ref ruby/ruby@2a56a6c
Ref ruby/ruby#7877
Alternatively, we could vendor
racc/parser
into Journey's generated parser but that then requires the parser to be regenerated to get any upstream improvementsChecklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]