Reload type map when creating or dropping PostgreSQL enums #49772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiculescu
approved these changes
Oct 24, 2023
|
Thank you for the pull request as always. Would you add some tests to make sure to avoid future regressions? |
fatkodima
force-pushed
the
reload-type_map-for-enums
branch
from
f90eb3c
to
c4a6d13
Compare
|
Added test case. |
akhilgkrishnan
approved these changes
Oct 27, 2023
yahonda
approved these changes
Oct 28, 2023
|
@yahonda Can you please also backport this to |
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Oct 29, 2023
Reload type map when creating or dropping PostgreSQL enums
|
Backported to the 7-1-stable branch via 9a58e00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49767.
All other enum-related methods are already reloading type map.
I am not sure are tests needed for this?
cc @ghiculescu (as implementor of the PostgreSQL
enum)