[Fix #49761] allow an injection of collection locals. #49780
Closed
+33
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
reviewed
Oct 25, 2023
HolyWalley
force-pushed
the
fix-strict-locals
branch
from
ae3624c
to
5afddaa
Compare
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Oct 25, 2023
Fix: rails#49780 Fix: rails#49761 `CollectionRenderer` implictly inject `<name>_counter` and `<name>_iteration` locals, but in the overwhelming majority of cases they aren't used. So when the rendered template has strict locals we shouldn't require these to be declared, and if they aren't we should simply not pass them. Co-Authored-By: HolyWalley <yakau@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Discussed in this issue #49761
Detail
This Pull Request allows ActionView::Template#render method to accept an array
injected_locals, which is an array of keys of locals that were inejected by rails, for example ActionView::Renderer::CollectionRenderer injects*_counterand*_iterationlocals. With those valuesrendermethod can filter out locals that were injected, but not specified in strict locals to prevent errors described in referring issue.Additional information
I'm not sure if I should add anything to changelog or documentation. From one side it's an internal change, from the other some docs might be updated. So, please, let me know if I should add any of the info to changelog/docs.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]