Fix upserting for custom :on_duplicate and :unique_by consisting of all inserts keys
#49870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of all inserts keys
fatkodima
force-pushed
the
fix-upsert-custom_on_duplicate-and-unique_by
branch
from
9c29602
to
3bf867d
Compare
akhilgkrishnan
approved these changes
Oct 31, 2023
|
Thank you, @fatkodima! 🆙 Backported to |
jonathanhefner
added a commit
that referenced
this pull request
Oct 31, 2023
…te-and-unique_by Fix upserting for custom `:on_duplicate` and `:unique_by` consisting of all inserts keys (cherry picked from commit f7bc844)
jonathanhefner
added a commit
that referenced
this pull request
Oct 31, 2023
…te-and-unique_by Fix upserting for custom `:on_duplicate` and `:unique_by` consisting of all inserts keys (cherry picked from commit f7bc844)
|
Thank you @fatkodima and @jonathanhefner for the quick solution! 👏🏻 👏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49867.
Before, when
@on_duplicate = :skip if @on_duplicate == :update && updatable_columns.empty?line run, it incorrectly ignores the fact that custom:on_duplicatewas passed and@on_duplicateis already configured in theconfigure_on_duplicate_update_logicmethod. So I moved that logic into that method.