Commits on Nov 7, 2023

1. Preload Selenium driver_path before parallelizing system tests …

   When the webdrivers gem is not present (which is the default scenario in
   Rails 7.1+), the Selenium `driver_path` starts out as `nil`. This means
   the driver is located lazily, and deferred until a system test is run.
   
   If parallel testing is used, this leads to a race condition, where each
   worker process tries to resolve the driver simultaneously. The result is
   an error as described in rails#49906.
   
   This commit fixes the race condition by changing the implementation of
   `Browser#preload`. The previous implementation worked when `driver_path`
   was set to a Proc by the `webdrivers` gem, but doesn't work when the
   `webdrivers` gem is not being used and the `driver_path` is `nil`.
   
   `Browser#preload` now uses the `DriverFinder` utility provided by the
   `selenium-webdriver` gem to eagerly resolve the driver path if needed.
   This will ensures that `driver_path` is set before parallel test workers
   are forked.
   
   Fixes rails#49906.
   
   Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>

   

   mattbrictson and jonathanhefner committed Nov 7, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for e7d743b
   • Browse repository at this point

   Copy the full SHA

   e7d743b View commit details

   Browse the repository at this point in the history