Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port type_for_attribute to Active Model #49910

Merged
merged 1 commit into from Nov 4, 2023
Merged

Port type_for_attribute to Active Model #49910

merged 1 commit into from Nov 4, 2023

Conversation

jonathanhefner
Copy link
Member

This moves type_for_attribute from ActiveRecord::ModelSchema::ClassMethods to ActiveModel::AttributeRegistration::ClassMethods, where attribute_types is also defined.

@jonathanhefner @p8
Port type_for_attribute to Active Model
83f543b 
This moves `type_for_attribute` from `ActiveRecord::ModelSchema::ClassMethods`
to `ActiveModel::AttributeRegistration::ClassMethods`, where
`attribute_types` is also defined.

Co-authored-by: Petrik <petrik@deheus.net>
@jonathanhefner jonathanhefner merged commit 7d525d3 into rails:main Nov 4, 2023
4 checks passed
@jonathanhefner jonathanhefner mentioned this pull request Nov 4, 2023
Closed
4 tasks
@seanpdoyle seanpdoyle mentioned this pull request Nov 6, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
activemodel activerecord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonathanhefner