Add actionview bug report template
#49986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
reviewed
Nov 10, 2023
seanpdoyle
force-pushed
the
action-view-bug-report-templates
branch
from
a7cd26c
to
d8ea067
Compare
seanpdoyle
force-pushed
the
action-view-bug-report-templates
branch
2 times, most recently
from
4ef181e
to
af7d911
Compare
rafaelfranca
requested changes
Nov 10, 2023
| end | ||
|
|
||
| def test_stuff | ||
| view.extend Helpers |
There was a problem hiding this comment.
This isn't how you add helpers to test cases, you use the helper class method.
There was a problem hiding this comment.
Thank you for calling that out! Is there somewhere in the documentation I could learn more about that? I can't find the method in the API docs
There was a problem hiding this comment.
There was a problem hiding this comment.
@rafaelfranca I've pushed up a change to use that method.
seanpdoyle
force-pushed
the
action-view-bug-report-templates
branch
from
af7d911
to
de0d492
Compare
|
I'm starting to wonder if we really need both main && gem variations, when the only real difference is one line: - gem "rails", github: "rails/rails", branch: "main"
+ gem "rails", "~> 7.1.0"It could just be a comment, right? |
Introduce Action View bug report template for contributors to reproduce issues with failing `ActionView::TestCase` instances. In addition to rendering ERB with the `inline:` keyword, the sample tests also include a `Helpers` module to demonstrate how to incorporate view helpers into the reproduction script.
seanpdoyle
force-pushed
the
action-view-bug-report-templates
branch
from
de0d492
to
fe2632f
Compare
|
CI failures seem unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Introduce Action View bug report templates for contributors to reproduce issues with failing
ActionView::TestCaseinstances.Detail
In addition to rendering ERB with the
inline:keyword, the sample tests also include aHelpersmodule to demonstrate how to incorporate view helpers into the reproduction script.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]