Fix renaming primary key index when renaming a PostgreSQL table having uuid primary key #49998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
18
to
19
| assert_changes(-> { num_indices_named("before_rename_pkey") }, from: 1, to: 0) do | ||
| assert_changes(-> { num_indices_named("after_rename_pkey") }, from: 0, to: 1) do |
There was a problem hiding this comment.
What do you think about factoring out an assert_renames_index(from, to, &block) helper method?
Comment on lines
35
to
32
| test "renaming a table with uuid primary key and default also renames the primary key index" do | ||
| @connection.create_table :before_rename, force: true, id: :uuid, default: -> { "gen_random_uuid()" } |
There was a problem hiding this comment.
Since gen_random_uuid is already the default function for PostgreSQL >= 9.4, this is exercising the same code path as the previous test. Perhaps both tests should specify a default, one for uuid_generate_v4 and one for gen_random_uuid?
…g uuid primary key
fatkodima
force-pushed
the
fix-pg-rename_table-with-uuid-pk
branch
from
54a78b9
to
7fba608
Compare
|
Implemented suggestions. Please take a look. |
|
Thank you, @fatkodima! 🔑 Backported to |
rafaelfranca
pushed a commit
that referenced
this pull request
Nov 10, 2023
…d-pk Fix renaming primary key index when renaming a PostgreSQL table having uuid primary key
jonathanhefner
added a commit
that referenced
this pull request
Nov 10, 2023
…d-pk Fix renaming primary key index when renaming a PostgreSQL table having uuid primary key (cherry picked from commit 16607e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49994.
Rails uses
gen_random_uuid()function as a default foruuidprimary key for PostgreSQL, which is not correctly fetched from the pg_catalog.