Arel nulls first/last implementation Mysql #50079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please squash your commits. |
tttffff
force-pushed
the
mysql_null_first_last_consistency
branch
from
75c5e63
to
98a85ec
Compare
Fixes rails#50079 where there is unexpected behaviour for MySQL Previously: - Calling nulls_first on asc worked as expected - Calling nulls_first on desc ordered desc nulls last - Calling nuls_last on asc raised error - Calling nulls_last on desc raised error Now: - Calling nulls_first on asc works as expected - Calling nulls_first on desc works as expected - Calling nulls_last on asc works as expected - Calling nulls_last on desc works as expected
tttffff
force-pushed
the
mysql_null_first_last_consistency
branch
from
98a85ec
to
059caa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #50078
This Pull Request has been created because I needed to sort a column ASC with nulls last with a MySQL database and wanted to avoid using an SQL fragment to achieve this. I discovered that Arel supports this for all databases apart from MySQL. When investigating the MySQL implementation, I noticed inconsistencies with how it is implemented.
Originally, I was just aiming to make the functionality consistent, but then had a go at implementing the missing functionality.
Detail
This Pull Request changes the implementation of
.nulls_first()and.nulls_last()for MySQL databases. These methods now work as designed.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]