Alias field_set_tag helper to fieldset_tag
#50241
Merged
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [field_set_tag][] renders a `<fieldset>` element. At times, the desire to render a `fieldset` results in calling `fieldset_tag`, only to be surprised by a `NoMethodError`. Originally, the method's name was `fieldset_tag` helper (defined in [0e6c8e5][] in 2007), but was renamed in [73c7083][] (3 days later). This commit aliases `field_set_tag` to `fieldset_tag` so that both are available. Additionally, defines the method so that it utilizes the [content_tag][] so that it isn't responsible for manually managing the closing (`</fieldset>`) of the opening `<fieldset>` tag. [field_set_tag]: https://edgeapi.rubyonrails.org/classes/ActionView/Helpers/FormTagHelper.html#method-i-field_set_tag [0e6c8e5]: rails@0e6c8e5 [73c7083]: rails@73c7083 [content_tag]: https://edgeapi.rubyonrails.org/classes/ActionView/Helpers/TagHelper.html#method-i-content_tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The field_set_tag renders a
<fieldset>element. At times, the desire to render afieldsetresults in callingfieldset_tag, only to be surprised by aNoMethodError.Originally, the method's name was
fieldset_taghelper (defined in 0e6c8e5 in 2007), but was renamed in 73c7083 (3 days later).Detail
This commit aliases
field_set_tagtofieldset_tagso that both are available.Additional information
Additionally, defines the method so that it utilizes the content_tag so that it isn't responsible for manually managing the closing (
</fieldset>) of the opening<fieldset>tag.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]