Fix system tests with Chrome cached by Selenium #50296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to rails#49908. When Selenium resolves the driver path to a copy of Chrome that it has downloaded / cached, it mutates the `Selenium::WebDriver::Chrome::Options` object it receives, and relies on those changes later when the options are used. If `Selenium::WebDriver::Chrome::Service.driver_path` is set but a different options object is used, Selenium will raise "cannot find Chrome binary". Therefore, this commit ensures that the options object passed to `Selenium::WebDriver::DriverFinder.path` is the same options object used by the driver later.
jonathanhefner
force-pushed
the
follow-up-49908-fix-cached-chrome
branch
from
aae1852
to
be272a8
Compare
jonathanhefner
added a commit
that referenced
this pull request
Dec 21, 2023
…hed-chrome Fix system tests with Chrome cached by Selenium (cherry picked from commit 049c951)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #49908.
When Selenium resolves the driver path to a copy of Chrome that it has downloaded / cached, it mutates the
Selenium::WebDriver::Chrome::Optionsobject it receives, and relies on those changes later when the options are used. IfSelenium::WebDriver::Chrome::Service.driver_pathis set but a different options object is used, Selenium will raise "cannot find Chrome binary". Therefore, this commit ensures that the options object passed toSelenium::WebDriver::DriverFinder.pathis the same options object used by the driver later.Fixes #50287.