Fix polymorphic belongs_to
to correctly use parent's query_constraints
#50321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50315.
For polymorphic association with query constraints, we get incorrect value for primary key (specifically,
"id"
in the referenced issue) hererails/activerecord/lib/active_record/reflection.rb
Lines 870 to 882 in 5c4a7a7
which then incorrectly matches with foreign key (specifically,
["tenant_id", "commentable_id"]
in the referenced issue) hererails/activerecord/lib/active_record/associations/association_scope.rb
Lines 58 to 63 in 5c4a7a7
With this change,
association_primary_key
now correctly returns["tenant_id", "id"]
.