Remove SQLite production warning but leave production config disabled#50463
Conversation
5bc8d49 to
11795be
Compare
| production: | ||
| <<: *default | ||
| database: storage/production.sqlite3 | ||
| # database: path/to/persistent/storage/production.sqlite3 |
There was a problem hiding this comment.
| # database: path/to/persistent/storage/production.sqlite3 | |
| # database: storage/production.sqlite3 |
I think just commenting it out is fine since most would probably use the default storage folder anyway, but persisted with something like Docker volumes.
|
This feels like a good compromise. But also wonder if we should support passing in a path using DATABASE_URL in production? |
Makes sense to me but is orthogonal. Best handled in another PR. |
|
Yeah I guess DATABASE_URL overwrites in any case. Looks good to me then 👍 |
|
Looks like |
|
I think I'll squeeze the |
There are valid use cases for running SQLite in production, however it must be done with care, so instead of a warning most users won't see anyway, it's preferable to leave the configuration commented out to force them to think about having the database on a persistent volume etc. Co-Authored-By: Jacopo Beschi <beschi.jacopo@gmail.com>
11795be to
6b446be
Compare
|
Actually it's already supported. |
- Update to Rails 8 and run `rails app:update` - Advise to install Node 22 - Improve dependabot - Remove sqlite production warning suppression as per rails/rails#50463
- Update to Rails 8 and run `rails app:update` - Advise to install Node 22 - Improve dependabot - Remove sqlite production warning suppression as per rails/rails#50463 - Use example domain for email in specs - Move some assertions on the current path below text assertions to give time to the server to persist the new resource
- Update to Rails 8 and run `rails app:update` - Advise to install Node 22 - Improve dependabot - Remove sqlite production warning suppression as per rails/rails#50463 - Use example domain for email in specs - Move some assertions on the current path below text assertions to give time to the server to persist the new resource
- Bump Rails to version 8.0 and execute `rails app:update` for configuration alignment - Recommend Node.js 22 for development and runtime compatibility - Enhance Dependabot configuration for improved dependency management - Remove suppression of SQLite production warning, addressing rails/rails#50463 - Use an example domain for email addresses in test suites - Reorder certain path assertions after text assertions in specs to ensure server state is persisted - Add the frozen string literal magic comment to Ruby files - Switch to Rails 8’s built-in rate limiter for request throttling Closes #637
- Bump Rails to version 8.0 and execute `rails app:update` for configuration alignment - Recommend Node.js 22 for development and runtime compatibility - Enhance Dependabot configuration for improved dependency management - Remove suppression of SQLite production warning, addressing rails/rails#50463 - Use an example domain for email addresses in test suites - Reorder certain path assertions after text assertions in specs to ensure server state is persisted - Add the frozen string literal magic comment to Ruby files - Switch to Rails 8’s built-in rate limiter for request throttling Closes #637
* Upgrade to Rails 8.0 and adopt new features - Bump Rails to version 8.0 and execute `rails app:update` for configuration alignment - Recommend Node.js 22 for development and runtime compatibility - Enhance Dependabot configuration for improved dependency management - Remove suppression of SQLite production warning, addressing rails/rails#50463 - Use an example domain for email addresses in test suites - Reorder certain path assertions after text assertions in specs to ensure server state is persisted - Add the frozen string literal magic comment to Ruby files - Switch to Rails 8’s built-in rate limiter for request throttling Closes #637 * Update app/controllers/application_controller.rb Co-authored-by: Javier Julio <JJfutbol@gmail.com> --------- Co-authored-by: Javier Julio <JJfutbol@gmail.com>
Fix: #49715
There are valid use cases for running SQLite in production, however it must be done with care, so instead of a warning most users won't see anyway, it's preferable to leave the configuration commented out to force them to think about having the database on a persistent volume etc.
Co-Authored-By: @intrip