Remove SQLite production warning but leave production config disabled #50463
Conversation
casperisfine
force-pushed
the
remove-sqlite3-production-warning
branch
from
5bc8d49
to
11795be
Compare
| production: | ||
| <<: *default | ||
| database: storage/production.sqlite3 | ||
| # database: path/to/persistent/storage/production.sqlite3 |
There was a problem hiding this comment.
| # database: path/to/persistent/storage/production.sqlite3 | |
| # database: storage/production.sqlite3 |
I think just commenting it out is fine since most would probably use the default storage folder anyway, but persisted with something like Docker volumes.
|
This feels like a good compromise. But also wonder if we should support passing in a path using DATABASE_URL in production? |
Makes sense to me but is orthogonal. Best handled in another PR. |
|
Yeah I guess DATABASE_URL overwrites in any case. Looks good to me then 👍 |
|
Looks like |
|
I think I'll squeeze the |
There are valid use cases for running SQLite in production, however it must be done with care, so instead of a warning most users won't see anyway, it's preferable to leave the configuration commented out to force them to think about having the database on a persistent volume etc. Co-Authored-By: Jacopo Beschi <beschi.jacopo@gmail.com>
casperisfine
force-pushed
the
remove-sqlite3-production-warning
branch
from
11795be
to
6b446be
Compare
|
Actually it's already supported. |
Fix: #49715
There are valid use cases for running SQLite in production, however it must be done with care, so instead of a warning most users won't see anyway, it's preferable to leave the configuration commented out to force them to think about having the database on a persistent volume etc.
Co-Authored-By: @intrip