Fix instantiation of inherited classes when querying #50553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvlara
changed the title
MatheusRich
reviewed
Jan 3, 2024
Edouard-chin
reviewed
Jan 5, 2024
jvlara
force-pushed
the
bugfix/fix-intantiation-of-attributes-on-inherited-classes-when-quering
branch
from
11a5219
to
c8ad876
Compare
|
Thanks 👍 . Someone from the core team will have a look and merge when they get a chance. |
Previously, querying from the base class resulted in an object of the inherited type, with 'ignored_columns' included in the 'attributes' method. This behavior was inconsistent, as it did not occur when querying directly from the inherited class. This fix ensures consistent behavior in class instantiation during queries.
jvlara
force-pushed
the
bugfix/fix-intantiation-of-attributes-on-inherited-classes-when-quering
branch
from
c8ad876
to
8c4764f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because #50499
Detail
Previously, querying from the base class resulted in an object of the inherited type, with 'ignored_columns' included in the 'attributes' method.
This behavior was inconsistent, as it did not occur when querying directly from the inherited class. This fix ensures consistent behavior in the attributes between the two ways of instantiate inherited classes during querying.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]