Define a class method to introspect valid delegatable types so they can #50662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be used to validate the type column and power strong parameters.
mhw
reviewed
Jan 19, 2024
| @@ -3007,6 +3007,7 @@ With this definition complete, our `Entry` delegator now provides the following | |||
|
|
|||
| | Method | Return | | |||
| |---|---| | |||
| | `Entry#entryable_types` | ["Message", "Comment"] | | |||
There was a problem hiding this comment.
#50819 @tanaken0515 fixed this already - thanks!
sampatbadhe
added a commit
to sampatbadhe/rails
that referenced
this pull request
May 12, 2024
Correct typo in activerecord changelog for -rails#50662
fractaledmind
pushed a commit
to fractaledmind/rails
that referenced
this pull request
May 13, 2024
Correct typo in activerecord changelog for -rails#50662
dhh
pushed a commit
that referenced
this pull request
May 14, 2024
Correct typo in activerecord changelog for -#50662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
While dealing with strong parameters in API requests and validating the polymorphic type field for a delegated type in a slightly abstract manner, its useful to have access to the allowed types.
Detail
This Pull Request changes the methods defined by ActiveRecord::DelegatedType
Additional information
N/A
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]