Allow schema_dump database config to be set via DATABASE_URL
#50745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a valuable thing to fix, but implementation wise I think it would make more sense to handle it in |
|
Thank you @byroot. I'll revise |
mscoutermarsh
force-pushed
the
schema-dump-url-config
branch
from
b88ef79
to
9b36082
Compare
In `database.yml`, `schema_dump` can currently be set to `false`, `nil` or a file path. I found that if you configure your database via DATABASE_URL, the false value does not work because it comes through as a string. This change allows `?schema_dump=false` to disable the dump via database_url.
mscoutermarsh
force-pushed
the
schema-dump-url-config
branch
from
9b36082
to
67549bc
Compare
|
Pushed an update to handle it in |
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Jan 15, 2024
…figurable via `DATABASE_URL` Fix: rails#50745 I went a bit farther and handled all the boolean configs, not just `schema_cache`. Co-Authored-By: Mike Coutermarsh <coutermarsh.mike@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
database.yml,schema_dumpcan currently be set tofalse,nilor a file path.I found that if you configure your database via DATABASE_URL, the false value does not work because it comes through as a string.
This change allows
?schema_dump=falseto disable the dump via database_url.Additional information
Original PR for
schema_dump#42804Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]