Fix rotation detection for HDR videos #50854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rails#50853 The video analyzer was relying on the positional reference of the Display Matrix side_data to fetch the rotation value. However, the side_data is not guaranteed to be in the same position. For instance, HDR videos shot on iOS have "DOVI configuration record" side_data in the first position, followed by the "Display Matrix" side data containing the rotation value. This fix removes the positional reference and explicitely searches for the "Display Matrix" side_data to retrieve the rotation angle.
railsbob
force-pushed
the
activestorage/analyze-rotated-video
branch
from
9f2a62b
to
0ff649a
Compare
|
The build timed out waiting on |
viralpraxis
pushed a commit
to viralpraxis/rails
that referenced
this pull request
Mar 24, 2024
Fixes rails#50853 The video analyzer was relying on the positional reference of the Display Matrix side_data to fetch the rotation value. However, the side_data is not guaranteed to be in the same position. For instance, HDR videos shot on iOS have "DOVI configuration record" side_data in the first position, followed by the "Display Matrix" side data containing the rotation value. This fix removes the positional reference and explicitely searches for the "Display Matrix" side_data to retrieve the rotation angle.
fractaledmind
pushed a commit
to fractaledmind/rails
that referenced
this pull request
May 13, 2024
Fixes rails#50853 The video analyzer was relying on the positional reference of the Display Matrix side_data to fetch the rotation value. However, the side_data is not guaranteed to be in the same position. For instance, HDR videos shot on iOS have "DOVI configuration record" side_data in the first position, followed by the "Display Matrix" side data containing the rotation value. This fix removes the positional reference and explicitely searches for the "Display Matrix" side_data to retrieve the rotation angle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #50853
Detail
The video analyzer was relying on the positional reference of side_data to fetch the rotation metadata. However, the side_data is not guaranteed to be in the same position for all videos. For instance, HDR videos shot on iOS in portrait mode have "DOVI configuration record" side_data in the first position, followed by the "Display matrix" side data containing the rotation value.
This fix removes the positional reference and explicitely searches for the "Display Matrix" side_data to retrieve the rotation angle.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]