Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display dev & test env in console prompt in blue instead of green #50855

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

st0012
Copy link
Contributor

@st0012 st0012 commented Jan 23, 2024

Motivation / Background

The combination of red and blue is more color-blind friendly than red and green.

Discussion: #50796 (comment)

Detail

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@byroot
Copy link
Member

byroot commented Jan 24, 2024

Interestingly one related test failed, but only on the 3.2 suite. I wonder if it's maybe an ordering issue?

Error:
Rails::ConsoleTest#test_prompt_env_colorization:
NameError: uninitialized constant Rails::ConsoleMethods
    test/commands/console_test.rb:62:in `new'
    test/commands/console_test.rb:62:in `test_prompt_env_colorization'
 
bin/rails test test/commands/console_test.rb:61

The combination of red and blue is more color-blind friendly than red
and green.

Discussion: rails#50796 (comment)
@st0012 st0012 force-pushed the update-console-prompt-color branch from 6fc1bd5 to 7cbf06c Compare January 24, 2024 11:07
@st0012
Copy link
Contributor Author

st0012 commented Jan 24, 2024

Yeah it's because that test case's setup was incomplete. I added a separate commit for the fix as it should be done regardless if we're changing the color or not.

@byroot byroot merged commit 2af2b22 into rails:main Jan 24, 2024
4 checks passed
@st0012 st0012 deleted the update-console-prompt-color branch January 24, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants