Rails test command suggests similar test files when the given file is not found #51005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
reviewed
Feb 13, 2024
Comment on lines
63
to
64
| ms = list_tests([default_test_glob]) | ||
| cs = DidYouMean::SpellChecker.new(dictionary: ms).correct(path) |
There was a problem hiding this comment.
Are ms and cs short for "misspelling" and "correct spelling"? Would replacing the abbreviations with long form words lose us anything?
There was a problem hiding this comment.
I'm not sure the original intention, so good call.
I went with all_tests and corrections, since the former is all of the tests using the default glob and corrections is obvious.
… not found. For example, if you run `rails test test/models/usr_tsst.rb` and the file does not exist, Rails will suggest `test/models/users_test.rb` as a possible file. ``` Could not load test file: test/models/usr_tsst.rb. Did you mean? test/models/user_test.rb ``` Co-authored-by: Aaron Patterson <aaron@rubyonrails.org>
zzak
force-pushed
the
test-runner-did-you-mean
branch
from
77df873
to
346f516
Compare
|
@byroot I think you were looking at minitest recently, do you think this makes sense, or we should rely on the behavior upstream? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if you run
rails test test/models/usr_tsst.rband the file does not exist, Rails will suggesttest/models/users_test.rbas a possible file.After investigating #50978, I was inspired to add this feature to Rails.
Credit to @tenderlove for the minitest implementation.