Add new middleware to ensure errors are always reported to the AS error reporter #51028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because it was reported in #51002 (comment) that the Rails error reporter is not reporting errors in production.
Fixes #51002
Detail
This moves the reporting to inside a new middleware, ReportErrors, which is always hit in prod and development and removes the reporting from the Executor middleware. Moving it here ensures errors are always reported regardless of the environment.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]