Action View Test Case rendered memoization
#51093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
seanpdoyle
commented
Feb 15, 2024
seanpdoyle
force-pushed
the
action-view-rendered-memoization
branch
2 times, most recently
from
c8a39b9
to
de23549
Compare
eugeneius
reviewed
Feb 15, 2024
Follow-up to [49856][] Follow-up to [49194][] The introduction of memoization as an optimization posed a backwards incompatible change to View tests that call `render` multiple times. This commit changes the `@rendered` instance variable from a `String` to an instance of the `RenderedViewContent` specialized `String` subclass. The end result is that there is no memoization to reset, and the memoization optimization side-effect is preserved after rendering for test cases where `rendered` (or parser methods like `rendered.html`) might be invoked more than once. [49856]: rails#49856 (comment) [49194]: https://github.com/rails/rails/pull/49194/files#diff-ce84a807f3491121a5230d37bd40454bb1407fcca71179e1a2fa76d4c0ddfa2aR293
seanpdoyle
force-pushed
the
action-view-rendered-memoization
branch
from
de23549
to
520cd8f
Compare
eugeneius
added a commit
that referenced
this pull request
Feb 15, 2024
…ation Action View Test Case `rendered` memoization
|
Thank you Sean! Backported to 7-1-stable in ddb959b. |
| @@ -283,30 +283,6 @@ const fileInputSelector = Rails.fileInputSelector | |||
| Rails.fileInputSelector(...) | |||
| ``` | |||
|
|
|||
| ### `ActionView::TestCase#rendered` no longer returns a `String` | |||
There was a problem hiding this comment.
@rafaelfranca https://github.com/rails/rails/pull/49856/files#diff-ce84a807f3491121a5230d37bd40454bb1407fcca71179e1a2fa76d4c0ddfa2aR302 changed that class inheritance hierarchy by making it inherit from String. That was back ported to 7-1-stable (in f7255ec, maybe? That commit's contents differ from its title line).
With that change in class hierarchy, this guidance became partly incorrect, since "ActionView::TestCase#rendered no longer returns a String" was no longer true. With the change in this commit from a method to an attr_reader, that guidance became entirely incorrect, since it's both a String and an attr_reader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The introduction of memoization as an optimization posed a backwards incompatible change to View tests that call
rendermultiple times.Detail
Follow-up to 49856
Follow-up to 49194
This commit changes the
@renderedinstance variable from aStringto an instance of theRenderedViewContentspecializedStringsubclass.The end result is that there is no memoization to reset, and the memoization optimization side-effect is preserved after rendering for test cases where
rendered(or parser methods likerendered.html) might be invoked more than once.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]