Support filenames in Logger.logger_outputs_to?
#51125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willnet
added a commit
to willnet/rails
that referenced
this pull request
Feb 27, 2024
….logger_outputs_to?` Fixed incorrect documentation for `ActiveSupport::Logger.logger_outputs_to?`. The method expects the first argument to be a Logger object and subsequent variadic arguments to be either IO objects or strings representing file paths. Also corrected the sample code in CHANGELOG.md, which previously only passed a single argument, not reflecting the correct usage. related PR: rails#51125
jathayde
pushed a commit
to jathayde/rails
that referenced
this pull request
Feb 28, 2024
….logger_outputs_to?` Fixed incorrect documentation for `ActiveSupport::Logger.logger_outputs_to?`. The method expects the first argument to be a Logger object and subsequent variadic arguments to be either IO objects or strings representing file paths. Also corrected the sample code in CHANGELOG.md, which previously only passed a single argument, not reflecting the correct usage. related PR: rails#51125
Ridhwana
pushed a commit
to Ridhwana/rails
that referenced
this pull request
Mar 7, 2024
….logger_outputs_to?` Fixed incorrect documentation for `ActiveSupport::Logger.logger_outputs_to?`. The method expects the first argument to be a Logger object and subsequent variadic arguments to be either IO objects or strings representing file paths. Also corrected the sample code in CHANGELOG.md, which previously only passed a single argument, not reflecting the correct usage. related PR: rails#51125
viralpraxis
pushed a commit
to viralpraxis/rails
that referenced
this pull request
Mar 24, 2024
….logger_outputs_to?` Fixed incorrect documentation for `ActiveSupport::Logger.logger_outputs_to?`. The method expects the first argument to be a Logger object and subsequent variadic arguments to be either IO objects or strings representing file paths. Also corrected the sample code in CHANGELOG.md, which previously only passed a single argument, not reflecting the correct usage. related PR: rails#51125
fractaledmind
pushed a commit
to fractaledmind/rails
that referenced
this pull request
May 13, 2024
….logger_outputs_to?` Fixed incorrect documentation for `ActiveSupport::Logger.logger_outputs_to?`. The method expects the first argument to be a Logger object and subsequent variadic arguments to be either IO objects or strings representing file paths. Also corrected the sample code in CHANGELOG.md, which previously only passed a single argument, not reflecting the correct usage. related PR: rails#51125
xjunior
pushed a commit
to xjunior/rails
that referenced
this pull request
Jun 9, 2024
….logger_outputs_to?` Fixed incorrect documentation for `ActiveSupport::Logger.logger_outputs_to?`. The method expects the first argument to be a Logger object and subsequent variadic arguments to be either IO objects or strings representing file paths. Also corrected the sample code in CHANGELOG.md, which previously only passed a single argument, not reflecting the correct usage. related PR: rails#51125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logger.logger_outputs_to?only supportsSTDOUTandSTDERR, notFileobjects or plain filenames.