Modified CollectionAssociation documentation to refer to the new class name #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is fine to change the header as well. No big deal, but looks good to be consistent with the class name. You could revise that bit through docrails directly. |
fxn
added a commit
that referenced
this pull request
May 11, 2011
Modified CollectionAssociation documentation to refer to the new class name
|
Cool stuff. Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been looking for an opportunity to help out for a little while, and I just noticed that there was one reference in CollectionAssociation's class docs to AssocationCollection. I also noticed that it was referenced (in a string) in the NamedScopeTest.
Also, should the header
# = Active Record Association Collectionbe changed to# = Active Record Collection Association?