Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception raised from template should not show compiled code #51304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikhilbhatt
Copy link
Contributor

@nikhilbhatt nikhilbhatt commented Mar 12, 2024

Motivation / Background

Fixes #51090

This Pull Request has been created to fix exceptions raised from template shows the compiled code.

Detail

This Pull Request changes activesupport/lib/active_support/core_ext/erb/util.rb

Additional information

  1. In this tokenize method we are not handling the text present after %>
  2. Updated that method to handle text present at end.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@nikhilbhatt
Copy link
Contributor Author

cc: @rafaelfranca

@nikhilbhatt nikhilbhatt force-pushed the fix_exception_raised_should_show_template_code branch from de41502 to e60ea9b Compare March 21, 2024 14:03
@nikhilbhatt
Copy link
Contributor Author

@byroot could you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions raised from templates should show template code not compiled methods
1 participant