Preserve encoding on truncate_bytes
#51313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String.new with no arguments returns the empty string with ASCII-8BIT encoding. Then, depending on each grapheme cluster of the string and on the omission string, the resulting string might keep the ASCII-8BIT encoding. With this change, we preserve the encoding of the original string instead. Note that String.new accepts an `encoding` keyword argument, like ``` String.new(encoding: Encoding::UTF_8) ``` However, instead of using that, we rely on `force_encoding` to set the original encoding. This is so that String subclasses don't need to preserve this keyword argument. For example, SafeBuffer doesn't. Thanks to @jeremy for catching this!
rosa
force-pushed
the
preserve-encoding-truncate-bytes
branch
from
74d898b
to
1095415
Compare
viralpraxis
pushed a commit
to viralpraxis/rails
that referenced
this pull request
Mar 24, 2024
String.new with no arguments returns the empty string with ASCII-8BIT encoding. Then, depending on each grapheme cluster of the string and on the omission string, the resulting string might keep the ASCII-8BIT encoding. With this change, we preserve the encoding of the original string instead. Note that String.new accepts an `encoding` keyword argument, like ``` String.new(encoding: Encoding::UTF_8) ``` However, instead of using that, we rely on `force_encoding` to set the original encoding. This is so that String subclasses don't need to preserve this keyword argument. For example, SafeBuffer doesn't. Thanks to @jeremy for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Under some circumstances,
String#truncate_bytescan return a string with a different encoding than the one being truncated. This is becauseString.newwith no arguments returns the empty string withASCII-8BITencoding. Then, depending on each grapheme cluster of the string and on the omission string, the resulting string might keep theASCII-8BITencoding. With this change, we preserve the encoding of the original string instead.Note that
String.newaccepts anencodingkeyword argument, so we could do something like:However, instead of using that, we rely on
force_encodingto set the original encoding. This is so that String subclasses don't need to preserve this keyword argument. For example,SafeBufferdoesn't. Thanks to @jeremy for catching this!Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]