Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hex bit strings with leading zeroes in postgresql #51375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jstanley0
Copy link

Motivation / Background

Currently when casting a hex string argument for a PostgreSQL bit or bit_varying column, leading zeroes are discarded. This is unexpected, and differs from the behavior of binary strings.

Detail

This Pull Request ensures leading zeroes are preserved, e.g. assigning a bit string column "0x5F" results in the bit string "01011111" instead of "1011111" being sent to Postgres.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@jstanley0
Copy link
Author

hmm. that test doesn't fail locally and also doesn't depend on the Postgres ActiveRecord adapter afaict

ensure leading zeroes are preserved, i.e. "0x0F" results in the
bit string "00001111" instead of "1111"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant