form_helper documentation using article instead of post [ci skip] #51376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notapatch
force-pushed
the
pr-form-with-update-documentation
branch
2 times, most recently
from
fea9275
to
55bd9f1
Compare
|
The only references to post in the form_helper file are now related to methods. Everything else is now article. Otherwise
Let me know if I can be of any assistance! |
notapatch
force-pushed
the
pr-form-with-update-documentation
branch
from
55bd9f1
to
7e40c80
Compare
rails-bot
bot
added
actionmailer
actionpack
activejob
activerecord
activesupport
docs
railties
labels
Documentation previously uses post which is confusing as the methods/verb is also post. Before <form action="/posts" method="post"> After <form action="/articles" method="post"> Method Worked through a new Rails app with scaffold of article and checking the output of the HTML. Other HTML changes make it more authentic: /> => at the end of the input
notapatch
force-pushed
the
pr-form-with-update-documentation
branch
from
7e40c80
to
4a44b51
Compare
|
Drat! I clearly didn't search for capital p Post! Thanks for catching that Carlos. Fixed! Work squashed. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because it will make the form_with documentation clearer.
Detail
Documentation previously uses post which is confusing as the methods/verb is also post.
Before
<form action="/posts" method="post">After
<form action="/articles" method="post">Method
Worked through a new Rails app with scaffold of article and checking the output of the HTML. Other HTML changes make it more authentic:
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]