Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fixes on JS page [ci skip] #51437

Merged
merged 1 commit into from Mar 30, 2024
Merged

Conversation

CodingItWrong
Copy link
Contributor

  • Makes capitalization of bundler tool names consistent with official docs (lowercase for esbuild, capitalized for others)
  • Fixes an instance of a double-hyphen command flag showing as an em-dash (or en-dash, not sure)
  • Fixes a sentence that does not read correctly since it was edited when adding Bun

@rails-bot rails-bot bot added the docs label Mar 28, 2024
Copy link
Member

@skipkayhil skipkayhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes, then can you squash your commits into one?

guides/source/working_with_javascript_in_rails.md Outdated Show resolved Hide resolved
guides/source/working_with_javascript_in_rails.md Outdated Show resolved Hide resolved
Co-authored-by: Hartley McGuire <skipkayhil@gmail.com>
@CodingItWrong
Copy link
Contributor Author

@skipkayhil Thanks! I've applied your fixes, squashed all the commits into one, and force-pushed it up

@skipkayhil skipkayhil merged commit 0a40f6e into rails:main Mar 30, 2024
3 checks passed
@skipkayhil
Copy link
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants