Make it possible to opt-out of sending Link header in preload_link_tag
#51441
+23
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
force-pushed
the
sh-opt-out-link-header-preload-link-tag
branch
from
d3e506a
to
662584f
Compare
skipkayhil
reviewed
Mar 28, 2024
stanhu
force-pushed
the
sh-opt-out-link-header-preload-link-tag
branch
from
662584f
to
4e94e69
Compare
This commit adds a `preload_links_header` option to `preload_link_tag` to disable sending of the Link header in the HTTP response. Currently `ActionView::Helpers::AssetTagHelper.preload_links_header` only controls whether `javascript_include_tag` and `stylesheet_link_tag` send the Link header, but there is no way to control the behavior of `preload_link_tag`. We could just check that variable, but existing applications might be relying on `preload_link_tag` to add the header. Users also might want control over this on a per call basis. Closes rails#51436
stanhu
force-pushed
the
sh-opt-out-link-header-preload-link-tag
branch
from
4e94e69
to
6578fbf
Compare
byroot
reviewed
Apr 26, 2024
| @@ -357,25 +357,26 @@ def preload_link_tag(source, options = {}) | |||
| crossorigin = "anonymous" if crossorigin == true || (crossorigin.blank? && as_type == "font") | |||
| integrity = options[:integrity] | |||
| nopush = options.delete(:nopush) || false | |||
| send_link_header = options.key?(:preload_links_header) ? options.delete(:preload_links_header) : true | |||
There was a problem hiding this comment.
I think early_hint: false would be a better name for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
preload_links_headeroption topreload_link_tagto disable sending of the Link header in the HTTP response.Currently
ActionView::Helpers::AssetTagHelper.preload_links_headeronly controls whetherjavascript_include_tagandstylesheet_link_tagsend the Link header, but there is no way to control the behavior ofpreload_link_tag. We could just check that variable, but existing applications might be relying onpreload_link_tagto add the header. Users also might want control over this on a per call basis.Closes #51436
Before submitting the PR make sure the following are checked:
[Fix #issue-number]