Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit deprecation warning about inverse_of inference only for valid reflections #51442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Emit deprecation warning about inverse_of inference only for valid reflections #51442

wants to merge 1 commit into from
+1 −1

Commits on Mar 28, 2024

  1. Emit deprecation warning about inverse_of inference only for valid re… 

    …flections

That is, if the reflection found is not valid, we don't want to emit the warning
because it's misleading. It says the inverse association could have been automatically
inferred but wasn't because `automatically_invert_plural_associations` is disabled.
However, this is not true, because later on, when we check whether the reflection
is valid, we see it's not, and end up returning `nil`.
    @rosa
    rosa committed Mar 28, 2024
    Copy the full SHA
    6758b86 View commit details
    Browse the repository at this point in the history