Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guides Dark Mode fixes #51444

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Guides Dark Mode fixes #51444

merged 3 commits into from
Mar 30, 2024

Commits on Mar 26, 2024

  1. Guides feedback fixes

    @claudioduarte in rails#51415
    
    - [x] Make alt, shorter SVG line for mobile, add responsive style
    - [x] Add side padding on footer (goes to edge on mobile, does not align on desktop)
    - [x] Shrink overall height of subCol so it doesn’t overlap footer
    
    @ivanjuric in rails#51398
    
    - [x] Flip inverted dark modes on “more Ruby on Rails” nav bar
    
    DHH/Core:
    
    - [x] Darker dark mode (Github style)
    - [x] Double box on WIP call out (index.html. editable?)
    - [x] NavBar bottom issue clipping on some guides (pad the content?)
    - [x] Rounded corners/better appearance on select form elements in header
    - [x] Black border on bottom of interstitials
    jathayde committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6174c5b View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Additional UI cleanup

    - [x] tightening up white space, adding Rails brand HR after intro
    - [x] base fontsize to 16px from 18px;
    - [x] fixing some darker dark mode issues in the last commit
    jathayde committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4218558 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Configuration menu
    Copy the full SHA
    ba67a59 View commit details
    Browse the repository at this point in the history