Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't preload Selenium browser when remote #51479

Merged
merged 1 commit into from Apr 18, 2024
Merged

Conversation

nhorton
Copy link
Contributor

@nhorton nhorton commented Apr 3, 2024

Motivation / Background

Fixes #50827

Detail

This Pull Request stops the preloading of the Selenium browser when the browser is remote.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • NA - Tests are added or updated if you fix a bug or add a feature.
  • NA - CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the actionpack label Apr 3, 2024
@nhorton
Copy link
Contributor Author

nhorton commented Apr 16, 2024

Anything else I can do to get this merged? I ended up with an easy workaround too, so can close if folks don't want it in. I just don't want to litter the open PR list...

@nathansamson
Copy link

Anything else I can do to get this merged? I ended up with an easy workaround too, so can close if folks don't want it in. I just don't want to litter the open PR list...

Can you share the workaround?

@rafaelfranca rafaelfranca merged commit d1236c4 into rails:main Apr 18, 2024
4 checks passed
rafaelfranca added a commit that referenced this pull request Apr 18, 2024
Don't preload Selenium browser when remote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System tests not working on Rails 7.1.3 running on a remote machine/docker container.
3 participants